Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly reports - next step #4239

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Feb 6, 2025

Following #4235

Add some tests to fix this violation:

* What went wrong:
Execution failed for task ':app:koverVerifyStates'.
> Rule 'Check code coverage of states' violated:
    instructions covered percentage for class 'io.element.android.features.lockscreen.impl.unlock.PinUnlockState' is 79.245300, but expected minimum is 90
    instructions covered percentage for class 'io.element.android.features.securebackup.impl.root.SecureBackupRootState' is 65.625000, but expected minimum is 90
    instructions covered percentage for class 'io.element.android.libraries.mediaviewer.impl.local.player.MediaPlayerControllerState' is 0.000000, but expected minimum is 90
    instructions covered percentage for class 'io.element.android.libraries.textcomposer.components.FormattingOptionState' is 0.000000, but expected minimum is 90

See https://github.com/element-hq/element-x-android/actions/runs/13176799102/job/36777908312

> Rule 'Check code coverage of states' violated:
    instructions covered percentage for class 'io.element.android.libraries.mediaviewer.impl.local.player.MediaPlayerControllerState' is 0.000000, but expected minimum is 90
    instructions covered percentage for class 'io.element.android.libraries.textcomposer.components.FormattingOptionState' is 0.000000, but expected minimum is 90
@bmarty bmarty requested a review from a team as a code owner February 6, 2025 15:52
@bmarty bmarty requested review from ganfra and removed request for a team February 6, 2025 15:52
@bmarty bmarty added the PR-Build For changes related to build, tools, CI/CD label Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/BtuQ8B

Copy link

sonarqubecloud bot commented Feb 6, 2025

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.07%. Comparing base (5456f0e) to head (54af229).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4239   +/-   ##
========================================
  Coverage    80.06%   80.07%           
========================================
  Files         2048     2048           
  Lines        54356    54357    +1     
  Branches      6633     6633           
========================================
+ Hits         43520    43525    +5     
+ Misses        8556     8555    -1     
+ Partials      2280     2277    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit de673c9 into develop Feb 6, 2025
30 checks passed
@bmarty bmarty deleted the feature/bma/fixNightlyReports2 branch February 6, 2025 16:27
@bmarty
Copy link
Member Author

bmarty commented Feb 6, 2025

One more thing to fix and we will be green

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant