Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user certificate in production builds. #4275

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Feb 17, 2025

Content

As discussed internally, we want the app to ba allowed to use installed user certificates if any.

Motivation and context

Let application access the home server in specific environment when a user certificate is required.

Note that this change has been validated by the security team.

Screenshots / GIFs

NA

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty added the PR-Misc For other changes label Feb 17, 2025
@bmarty bmarty requested a review from a team as a code owner February 17, 2025 16:12
@bmarty bmarty requested review from ganfra and removed request for a team February 17, 2025 16:12
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/svL2oN

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.06%. Comparing base (728a2c1) to head (a4e7e4c).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4275   +/-   ##
========================================
  Coverage    80.06%   80.06%           
========================================
  Files         2051     2051           
  Lines        54574    54574           
  Branches      6666     6666           
========================================
  Hits         43695    43695           
  Misses        8594     8594           
  Partials      2285     2285           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 90fbacd into develop Feb 18, 2025
30 checks passed
@bmarty bmarty deleted the feature/bma/userCertificates branch February 18, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants