-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare application for being configurable #4285
Conversation
New enterprise module was not correctly detected. Also ensure that the files are correctly found.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4285 +/- ##
===========================================
- Coverage 80.13% 80.12% -0.01%
===========================================
Files 2052 2052
Lines 54576 54590 +14
Branches 6672 6675 +3
===========================================
+ Hits 43733 43742 +9
- Misses 8560 8564 +4
- Partials 2283 2284 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
flavorShortDescription = BuildConfig.SHORT_FLAVOR_DESCRIPTION, | ||
) | ||
): BuildMeta { | ||
val applicationName = ApplicationConfig.APPLICATION_NAME.takeIf { it.isNotEmpty() } ?: context.getString(R.string.app_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should have different variants for desktop and production app names for the enterprise case too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe. We will update the code if this is a new requirement. FTR iOS did the same here: https://github.com/element-hq/element-enterprise/blob/d9c2d058d901872d3a0e8ea55e5f3ff806836c37/Templates/iOS/XcodeGen.pkl#L10-L11
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, I missed the Anvil issue.
Content
Move all fields used at build time to a single place.
Prepare the app to be able to customize the default homeserver URL.
There should be no impact on the current EXA application.
Motivation and context
Preparatory work for Element Enterprise.
Screenshots / GIFs
Tests
Tested devices
Checklist