-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show error screens in group calls #4297
Conversation
Element Call now sends a 'close' widget action when the widget is ready to close. Usually this will be sent immediately after the 'hangup' action, but it could be sent later if the widget wants to present an error screen before closing. So by listening to the 'close' action rather than the 'hangup' action, we get to see these error screens.
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
The test failure looks unrelated, would someone on the team try re-running it for me? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take care of the failing test, you're right, it's unrelated.
This PR can be merged, thanks!
OK, please don't merge it until I've taken the 'blocked' label off though, as I'm waiting for the linked Element Call change to be ready |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4297 +/- ##
===========================================
- Coverage 80.12% 80.11% -0.01%
===========================================
Files 2053 2053
Lines 54615 54616 +1
Branches 6686 6686
===========================================
- Hits 43761 43758 -3
- Misses 8565 8566 +1
- Partials 2289 2292 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This should not be merged until the criteria at element-hq/element-call#2955 (comment) are met. |
@bmarty You can merge this now, thank you! |
Content
Element Call now sends a 'close' widget action when the widget is ready to close. Usually this will be sent immediately after the 'hangup' action, but it could be sent later if the widget wants to present an error screen before closing. So by listening to the 'close' action rather than the 'hangup' action, we get to see these error screens.
Motivation and context
element-hq/element-call#2955
Depends on element-hq/element-call#3011
Screenshots / GIFs
Tests
Tested devices
Checklist