Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preload account urls #4301

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Preload account urls #4301

merged 3 commits into from
Feb 26, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Feb 25, 2025

Content

Preload account management URL into SDK memory cache.

Motivation and context

Closes #4300

Screenshots / GIFs

Tests

  • Signin using an OIDC managed account
  • Open the settings
  • All the items in the settings screen should load instantely.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

It will populate the SDK in-memory cache.
@bmarty bmarty requested a review from a team as a code owner February 25, 2025 14:46
@bmarty bmarty requested review from jmartinesp and removed request for a team February 25, 2025 14:46
@bmarty bmarty added the PR-Bugfix For bug fix label Feb 25, 2025
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/nAny2v

@bmarty bmarty changed the title Feature/bma/preload account url Preload account urls Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.12%. Comparing base (1a7a8a8) to head (da19835).
Report is 21 commits behind head on develop.

Files with missing lines Patch % Lines
.../android/libraries/matrix/test/FakeMatrixClient.kt 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4301   +/-   ##
========================================
  Coverage    80.12%   80.12%           
========================================
  Files         2053     2053           
  Lines        54615    54620    +5     
  Branches      6686     6686           
========================================
+ Hits         43761    43766    +5     
  Misses        8565     8565           
  Partials      2289     2289           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bmarty bmarty merged commit d746f59 into develop Feb 26, 2025
28 checks passed
@bmarty bmarty deleted the feature/bma/preloadAccountURL branch February 26, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Preload account management URLs
2 participants