Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade SDK version to 25.02.26 #4305

Merged
merged 8 commits into from
Feb 26, 2025
Merged

Upgrade SDK version to 25.02.26 #4305

merged 8 commits into from
Feb 26, 2025

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Feb 25, 2025 •
edited
Loading

Content

Changes:

  • Upgrade the Rust SDK bindings to v25.02.26.
  • Remove logic that opened the OIDC callback URL on logout as it's no longer needed, the SDK already handles this.
  • Improve how we handle retrieving and destroying SDK Room instances so we don't run into issues where the timeline is not reset when reloading a room because it's still being held somewhere, or the opposite where the timeline was destroyed eagerly and now the methods associated with it won't work.
  • Disable the Typos lint check that was making app:debugLint fail.

Motivation and context

Upgrade to the latest version of the SDK.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 15

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@jmartinesp jmartinesp added the PR-Dependencies Pull requests that update a dependency file label Feb 25, 2025
@jmartinesp jmartinesp requested a review from a team as a code owner February 25, 2025 16:21
@jmartinesp jmartinesp requested review from bmarty and removed request for a team February 25, 2025 16:21
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/VLBSWq

@codecov Codecov
Copy link

codecov bot commented Feb 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.13%. Comparing base (1a7a8a8) to head (784e562).
Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
...es/messages/impl/draft/MatrixComposerDraftStore.kt 0.00% 2 Missing ⚠️
...d/features/lockscreen/impl/unlock/PinUnlockView.kt 0.00% 0 Missing and 1 partial ⚠️
...droid/features/logout/impl/DefaultLogoutUseCase.kt 0.00% 1 Missing ⚠️
...rifysession/impl/outgoing/VerifySelfSessionView.kt 0.00% 0 Missing and 1 partial ⚠️
.../android/libraries/matrix/impl/RustMatrixClient.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4305      +/-   ##
===========================================
+ Coverage    80.12%   80.13%   +0.01%     
===========================================
  Files         2053     2052       -1     
  Lines        54615    54595      -20     
  Branches      6686     6683       -3     
===========================================
- Hits         43761    43751      -10     
+ Misses        8565     8554      -11     
- Partials      2289     2290       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bmarty
bmarty approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

.../logout/impl/src/main/kotlin/io/element/android/features/logout/impl/DefaultLogoutUseCase.kt Outdated
@@ -19,7 +19,7 @@ class DefaultLogoutUseCase @Inject constructor(
private val authenticationService: MatrixAuthenticationService,
private val matrixClientProvider: MatrixClientProvider,
) : LogoutUseCase {
override suspend fun logout(ignoreSdkError: Boolean): String? {
override suspend fun logout(ignoreSdkError: Boolean) {
val currentSession = authenticationService.getLatestSessionId()
return if (currentSession != null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the return word can be removed.

libraries/ui-strings/build.gradle.kts Outdated

lint {
disable += "Typos"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer that we fix the typos in Localazy when spotted. Was there some false positive?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one about 'media' in Norwegian, although maybe it's a valid typo:

element-x-android/libraries/ui-strings/src/main/res/values-nb/translations.xml:261: Error: "media" is a common misspelling; did you mean "medier"? [Typos]
    <string name="screen_media_upload_preview_error_failed_processing">"Kunne ikke behandle media for opplasting, vennligst prøv igjen."</string>

It breaks the lint check for me locally every single time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll address this in a separate PR, no worries.

@bmarty bmarty mentioned this pull request Feb 26, 2025
Closed
1 task
@jmartinesp jmartinesp changed the title Upgrade SDK version to 25.02.25 Upgrade SDK version to 25.02.26 Feb 26, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jmartinesp jmartinesp enabled auto-merge (squash) February 26, 2025 08:54
@jmartinesp jmartinesp disabled auto-merge February 26, 2025 08:54
@jmartinesp jmartinesp enabled auto-merge (squash) February 26, 2025 08:54
@jmartinesp jmartinesp merged commit dbb1de1 into develop Feb 26, 2025
26 checks passed
@jmartinesp jmartinesp deleted the misc/upgrade-sdk branch February 26, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
PR-Dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmartinesp @bmarty