Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runQualityChecks task shouldn't fail fast #4309

Merged
merged 4 commits into from
Feb 26, 2025

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Feb 26, 2025

Content

Changes:

  • Make sure we run every task it depends on so we get a list with all the issues instead of having to retry several times.
  • Tweak runQualityChecks task to make sure all Android lint tasks run.
  • Fix the CI flow so it works the same as when we run it locally to make sure the results match.

Motivation and context

It's a pain to have to run runQualityChecks several times just to get the next list of issues once we've fixed the current one.

Tests

  • Add some issue for the runQualityChecks task to discover. Check finding the error doesn't stop the rest of the tasks from running too.

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

Make sure we run every task it depends on so we get a list with all the issues instead of having to retry several times.
Copy link
Contributor

github-actions bot commented Feb 26, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/7rFzYC

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.16%. Comparing base (dbb1de1) to head (949d5ce).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4309   +/-   ##
========================================
  Coverage    80.16%   80.16%           
========================================
  Files         2058     2058           
  Lines        54770    54770           
  Branches      6705     6705           
========================================
  Hits         43908    43908           
  Misses        8564     8564           
  Partials      2298     2298           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp added the PR-Build For changes related to build, tools, CI/CD label Feb 26, 2025
@jmartinesp jmartinesp marked this pull request as ready for review February 26, 2025 11:07
@jmartinesp jmartinesp requested a review from a team as a code owner February 26, 2025 11:07
@jmartinesp jmartinesp requested review from bmarty and removed request for a team February 26, 2025 11:07
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmartinesp jmartinesp merged commit fe99ec0 into develop Feb 26, 2025
29 checks passed
@jmartinesp jmartinesp deleted the fix/run-all-lint-steps-in-run-quality-checks branch February 26, 2025 17:34
@bmarty bmarty mentioned this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants