-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runQualityChecks task shouldn't fail fast #4309
runQualityChecks task shouldn't fail fast #4309
Conversation
Make sure we run every task it depends on so we get a list with all the issues instead of having to retry several times.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4309 +/- ##
========================================
Coverage 80.16% 80.16%
========================================
Files 2058 2058
Lines 54770 54770
Branches 6705 6705
========================================
Hits 43908 43908
Misses 8564 8564
Partials 2298 2298 ☔ View full report in Codecov by Sentry. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Content
Changes:
runQualityChecks
task to make sure all Android lint tasks run.Motivation and context
It's a pain to have to run
runQualityChecks
several times just to get the next list of issues once we've fixed the current one.Tests
runQualityChecks
task to discover. Check finding the error doesn't stop the rest of the tasks from running too.Checklist