Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(read receipt): track read receipts for focused timeline #4374

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Mar 7, 2025

Content

What the title says.

Motivation and context

To display read receipts in focused timeline (permalink)

Screenshots / GIFs

No ui change.

Tests

  • Open permalink in the past
  • Check read receipts are displayed on the past timeline

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@ganfra ganfra added the PR-Bugfix For bug fix label Mar 7, 2025
@ganfra ganfra changed the title change(read receipt): track read receipts for focused timeline fix(read receipt): track read receipts for focused timeline Mar 7, 2025
@ganfra ganfra marked this pull request as ready for review March 7, 2025 08:59
@ganfra ganfra requested a review from a team as a code owner March 7, 2025 08:59
@ganfra ganfra requested review from bmarty and removed request for a team March 7, 2025 08:59
Copy link
Contributor

github-actions bot commented Mar 7, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/2pewkD

Copy link

sonarqubecloud bot commented Mar 7, 2025

@ganfra ganfra enabled auto-merge March 7, 2025 09:06
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.12%. Comparing base (6aca8d3) to head (67af88d).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...droid/libraries/matrix/impl/room/RustMatrixRoom.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4374      +/-   ##
===========================================
- Coverage    80.13%   80.12%   -0.01%     
===========================================
  Files         2058     2058              
  Lines        54794    54795       +1     
  Branches      6713     6713              
===========================================
  Hits         43907    43907              
- Misses        8591     8592       +1     
  Partials      2296     2296              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ganfra ganfra merged commit 9f43135 into develop Mar 7, 2025
31 of 32 checks passed
@ganfra ganfra deleted the feature/fga/focused_timeline_read_receipt branch March 7, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants