Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate some icons to Compound icon #4375

Merged
merged 5 commits into from
Mar 7, 2025
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Mar 7, 2025

Content

There was still some icon which was using drawables.

Missing icons are tracked by element-hq/compound#316

Motivation and context

Less custom icons.

Screenshots / GIFs

See recorded ones.

Tests

  • Should have no impact

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner March 7, 2025 13:23
@bmarty bmarty requested review from ganfra and removed request for a team March 7, 2025 13:23
@bmarty bmarty added the PR-Misc For other changes label Mar 7, 2025
Copy link
Contributor

github-actions bot commented Mar 7, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/wHdjzw

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 92.45283% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.13%. Comparing base (9f43135) to head (f645a1b).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...s/designsystem/theme/components/IconColorButton.kt 90.90% 0 Missing and 3 partials ⚠️
...atures/call/impl/services/CallForegroundService.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4375   +/-   ##
========================================
  Coverage    80.12%   80.13%           
========================================
  Files         2058     2057    -1     
  Lines        54795    54812   +17     
  Branches      6713     6715    +2     
========================================
+ Hits         43907    43923   +16     
  Misses        8592     8592           
- Partials      2296     2297    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

sonarqubecloud bot commented Mar 7, 2025

@bmarty bmarty merged commit c8ad1e2 into develop Mar 7, 2025
28 checks passed
@bmarty bmarty deleted the feature/bma/moreWorkOnIcons branch March 7, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants