Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More PR checks #4384

Merged
merged 3 commits into from
Mar 10, 2025
Merged

More PR checks #4384

merged 3 commits into from
Mar 10, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Mar 10, 2025

Content

Add more checks on PR.

Imported and adapted from https://github.com/matrix-org/matrix-js-sdk/blob/develop/.github/workflows/pull_request.yaml

Motivation and context

Less manual work.

Screenshots / GIFs

Tests

  • Check the CI behavior.

Tested devices

  • NA

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty added the PR-Build For changes related to build, tools, CI/CD label Mar 10, 2025
@bmarty bmarty requested a review from a team as a code owner March 10, 2025 09:00
@bmarty bmarty requested review from ganfra and removed request for a team March 10, 2025 09:00
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Mar 10, 2025
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/XbGBmk

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.12%. Comparing base (7e8ed31) to head (e5664f1).
Report is 18 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4384   +/-   ##
========================================
  Coverage    80.12%   80.12%           
========================================
  Files         2057     2057           
  Lines        54840    54840           
  Branches      6716     6716           
========================================
  Hits         43943    43943           
  Misses        8598     8598           
  Partials      2299     2299           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty merged commit 7690349 into develop Mar 10, 2025
36 checks passed
@bmarty bmarty deleted the feature/bma/prChecks branch March 10, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants