Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use public icon from Compound #4386

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Use public icon from Compound #4386

merged 2 commits into from
Mar 10, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Mar 10, 2025

Content

Remove drawable and use icon from Compound.

Motivation and context

https://www.figma.com/design/0MMNu7cTOzLOlWb7ctTkv3/Element-X?node-id=6703-149793

Screenshots / GIFs

See recorded ones.

Tests

  • NA

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty added the PR-Misc For other changes label Mar 10, 2025
@bmarty bmarty requested a review from a team as a code owner March 10, 2025 15:02
@bmarty bmarty requested review from ganfra and removed request for a team March 10, 2025 15:02
@bmarty bmarty enabled auto-merge March 10, 2025 15:06
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/51NWGM

@bmarty bmarty merged commit 5123db5 into develop Mar 10, 2025
30 checks passed
@bmarty bmarty deleted the feature/bma/publicIcon branch March 10, 2025 15:18
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.12%. Comparing base (f73c0e4) to head (94168c5).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4386   +/-   ##
========================================
  Coverage    80.12%   80.12%           
========================================
  Files         2064     2064           
  Lines        54998    54998           
  Branches      6742     6742           
========================================
  Hits         44065    44065           
  Misses        8631     8631           
  Partials      2302     2302           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants