Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Core Team" is a team of matrix-org. Use team "Vector Core" instead. #4393

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Mar 11, 2025

Fix CI giving label community to PR from us.

@bmarty bmarty requested a review from a team as a code owner March 11, 2025 12:58
@bmarty bmarty requested review from ganfra and removed request for a team March 11, 2025 12:58
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Mar 11, 2025
Copy link
Contributor

github-actions bot commented Mar 11, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/A4xFrn

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.09%. Comparing base (44b837a) to head (bb39d32).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4393   +/-   ##
========================================
  Coverage    80.09%   80.09%           
========================================
  Files         2064     2064           
  Lines        55040    55040           
  Branches      6746     6746           
========================================
  Hits         44086    44086           
  Misses        8648     8648           
  Partials      2306     2306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty
Copy link
Member Author

bmarty commented Mar 11, 2025

This does not work:

image

Checking again

@bmarty bmarty added the PR-Build For changes related to build, tools, CI/CD label Mar 11, 2025
@ganfra
Copy link
Member

ganfra commented Mar 11, 2025

This does not work:

image Checking again

Doesn't it need to be merged to be active?

@bmarty
Copy link
Member Author

bmarty commented Mar 11, 2025

The run seems to use the correct new value:

image

@guillaumevillemont
Copy link
Contributor

Can you try using ELEMENT_BOT_TOKEN_READ_ORG as the token instead ?

I believe ELEMENT_BOT_TOKEN only has repositories access. I created a new token as I didn't want to edit a token potentially used in other workflow.

@bmarty
Copy link
Member Author

bmarty commented Mar 11, 2025

@guillaumevillemont is it an organization secret? Double checking since I do not see this now token listed in https://github.com/element-hq/element-x-android/settings/secrets/actions

@guillaumevillemont
Copy link
Contributor

guillaumevillemont commented Mar 11, 2025

@bmarty I failed at ticking the right repo name 🤦‍♂️ Should be good now

@bmarty bmarty removed the Z-Community-PR Issue is solved by a community member's PR label Mar 11, 2025
@bmarty
Copy link
Member Author

bmarty commented Mar 11, 2025

OK, I have changed the token. Let's see what happening on the next created PR.

@bmarty bmarty merged commit 2ca492c into develop Mar 11, 2025
28 checks passed
@bmarty bmarty deleted the feature/bma/fixWrongTeam branch March 11, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants