Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gtk4Prep]Simplify iconrenderer construction and setup #2378

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Jan 18, 2024

Extracted from #2365

@jeremypw jeremypw changed the title Simplify iconrenderer construction and setup [Gtk4Prep]Simplify iconrenderer construction and setup Jan 19, 2024
@jeremypw jeremypw marked this pull request as ready for review January 19, 2024 19:33
@jeremypw jeremypw requested a review from a team January 19, 2024 19:33
@@ -33,7 +33,7 @@ namespace Files {
public Gdk.Rectangle hover_rect;
public int lpad {get; set; default = 0;}
public Files.File? drop_file {get; set;}

public bool show_emblems { get; set; default = false; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this change. Much less magic, much more explicit

@danirabbit danirabbit merged commit e421bec into main Jan 19, 2024
4 checks passed
@danirabbit danirabbit deleted the jeremypw/gtk4prep-iconrenderer branch January 19, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants