Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve thumbnailing Part3: Refresh thumbnail after edit #2460

Merged
merged 7 commits into from
Aug 27, 2024
Merged

Improve thumbnailing Part3: Refresh thumbnail after edit #2460

merged 7 commits into from
Aug 27, 2024

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Aug 25, 2024 •
edited
Loading

#Fixes #2327
Cherry-picked from #2340

  • React to CHANGES_DONE_HINT monitor event.
  • Invalidate loaded thumbnail after changed
  • Ignore duplicate and transient events
  • Only use large thumbnails (consequent to recent change)

@jeremypw jeremypw marked this pull request as ready for review August 25, 2024 18:03
danirabbit
danirabbit approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this fixes the linked issue and code makes sense to me 🚀

@danirabbit danirabbit merged commit 688c841 into main Aug 27, 2024
4 checks passed
@danirabbit danirabbit deleted the jeremypw/refresh-thumb-on-edit branch August 27, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The thumbnail does not update?
2 participants
@jeremypw @danirabbit