Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkspaceManager: Fix crash on workspace removed #2281

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

leolost2605
Copy link
Member

Tries to do the same as #2243.
It also fixes some warnings g_object_notify: assertion 'G_IS_OBJECT (object)' failed.

The reason from the code comment:

We might be here because of a signal emition from the ws machinery (e.g. workspace.window_removed).
Often the function emitting the signal doesn't take a ref on the ws so if we remove it right
away it will be freed. But because the function often accesses it after the singal emition this leads
to warnings and in some cases a crash.

Might fix #2242, #2227, #2232.
Fixes the crash described in #2258

@leolost2605 leolost2605 requested a review from a team February 24, 2025 19:24
@leolost2605 leolost2605 mentioned this pull request Feb 24, 2025
1 task
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lenemter lenemter merged commit 2fe02e5 into main Feb 24, 2025
5 checks passed
@lenemter lenemter deleted the leolost/fix-ws-removed-crash branch February 24, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gala crashes when opening specific files in flatpak Inkscape 1.4
2 participants