ImapDialog: use Adw.NavigationView #283
Conversation
|
I've left some comments about possible mem leaks. Because this is not a continually running process mem leaks aren't that bad here but I think we should kinda get aware of them because e.g. in dock we probably have quite a bunch since it starts with 200mb and after an hour or two of normal use it has 800mb :( |
|
@leolost2605 How's that? :) |
There was a problem hiding this comment.
Still not quite perfect I left a few comments.
I'm still trying to write a somewhat good explanation but for a start I left some more info here elementary/terminal#760 (comment).
To test it you can add a destructor and put a warning in it to see if it gets destroyed on close. Note though that on master it also doesn't get destroyed currently and only if you comment out a lot of the signal connections so for this class this might not be the best test.
To see whether the things you touched are problematic you can open the c file and make sure the lambdas that are handling signals that you worked on are connected with g_signal_connect_object and not g_signal_connect_full.
Kinda annoying I know :/
|
@leolost2605 okay how's this? I don't see any signal_connect_full in the generated C |
|
Sorry I typed it on my phone without checking, it should have been |
|
@leolost2605 it looks like there was only one of those so I went ahead of fixed it even though it's not related to this branch :) |
Replaces deprecated Leaflet