Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert hard-coded black & white colors in themes #684

Closed
wants to merge 4 commits into from

Conversation

Antolius
Copy link
Member

resolves #682

Invert white and bright white with black and bright black when switching between dark and light theme.

Invert white and bright white with black and bright black when switching from dark to light theme.
@Antolius Antolius marked this pull request as draft September 12, 2022 22:33
@Antolius
Copy link
Member Author

I marked this one as a draft since it will probably require a lot more testing to make sure the change doesn't introduce more problems than it solves.

@jeremypw
Copy link
Collaborator

jeremypw commented Nov 3, 2024

@Antolius The issue associated with this PR is now marked "Closed" following the merging of #755. If this PR solves other issues could you (create and) link them? If you think the original issue is not satisfactorily solved then maybe re-open it?

@Antolius
Copy link
Member Author

Antolius commented Nov 4, 2024

@jeremypw tnx for checking in! This is a pretty old PR and #755 seems like a safer solution anyway. So I'll just close this one.

@Antolius Antolius closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color issue in new version of Terminal
3 participants