Fix inoperative header decorations when fullscreened #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marukesu
reviewed
Dec 9, 2023
danirabbit
requested changes
Jan 9, 2024
Dont focus unfullscreen button Co-authored-by: Danielle Foré <danielle@elementary.io>
Style unfullscreen button Co-authored-by: Danielle Foré <danielle@elementary.io>
|
@Marukesu Thanks for the suggestion - can it be left for another PR? The current version of epiphay in 7.1 only has a "maximise" button in the headerbar. It does have a "fullscreen"button in the AppMenu though. |
|
@jeremypw you already implemented my suggestion. a fullscreen button in the menu would be good indeed, but that can be left to another PR. |
danirabbit
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #752
When fullscreened, the default decoration is overridden to show only the Close button (which still works) and a custom "Exit Fullscreen" button is revealed to replace the inoperative "Maximize/UnMaximise" button (with the same icon but with a Granite tooltip). This follows the method used by Epiphany (except that Epiphany does not use a tooltip).
If this solution is accepted then it could also be used for e.g. Code which has the same issue.