Use Gtk.Menu #770
Merged
Use Gtk.Menu #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you have used Gtk.Menu instead of GLib.Menu to get the accel labels back. This will have to be changed for Gtk4 as Gtk.Menu does not exist there but hopefully by then there will be a way of showing accel labels in GLib.Menu? |
jeremypw
approved these changes
Aug 9, 2024
|
It still uses Glib.Menu for the model it just uses GTK.Menu instead of GTK.PopoverMenu. The implementation of PopoverMenu in GTK4 is much better and does show accels |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs some CSS here to fix stylesheet bugs, but this will show accelerators. Gotta make the section labels null or we get a weird bug with separator height being forced to match an empty label