Fix "Open in Terminal" from Files when Terminal instance already running #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed in favour of #777. It appears it was the escaping of the uri of the working directory alone that was causing the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #775
The exact reason is uncertain but it appears that passing the working directory via the platform-data fails in some cases. The solution suggested here does not remove the "working-directory" commandline option after setting the CWD and uses that to determine where to open the tab when it is available, falling back to the CWD when it is not.
The sanitization of the uri no longer escapes the uri as this is not needed (and can cause problems)