Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable maxiter in bo utils minimize #476

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Conversation

hpesonen
Copy link
Member

@hpesonen hpesonen commented Feb 5, 2024

Summary:

Before maxiter=1000 was not used at all in minimize, now it's passed to scipy.optimize.minimize

Please make sure

  • You have read contribution guidelines
  • You have updated CHANGELOG.rst
  • You have listed the copyright holder for the work you are submitting (see next section)

If your contribution adds, removes or somehow changes the functional behavior of the package, please check that

  • You have included or updated all the relevant documentation, including docstrings
  • You have added appropriate functional and unit tests to ensure the new features behave as expected
  • You have run make lint, make docs and make test

and the proposed changes pass all unit tests (check step 6 of CONTRIBUTING.rst for details)

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

@hpesonen

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@uremes uremes merged commit 81514da into dev Mar 13, 2024
4 checks passed
@uremes uremes deleted the Enable_maxiter_in_bo_utils_minimize branch March 15, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants