Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: managed jvm21 toolchain, pt 2 #6

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Jan 22, 2025

Testing with GHA.

  • Punchlist
    • New hashes for GVM install step
    • Integration test using JVM 17
    • Multi-JDK testing
    • Kotlin ABI checks
    • Carefully update lockfiles
    • Drop GHA scaffolding
  • Known Issues
    • pkl-gradle: Broken tests
      • ModuleSupport: Natives not loaded; needs JNI init from resources
    • JDK 17: Need to fix exports for fat JAR consumers
      • Add JAR manifest attribute at Add-Exports

@sgammon sgammon self-assigned this Jan 22, 2025
@sgammon sgammon force-pushed the feat/jdk21-truffle24-x branch from cf70a31 to 470b5d3 Compare January 22, 2025 03:15
@sgammon sgammon mentioned this pull request Jan 22, 2025
3 tasks
@sgammon sgammon force-pushed the feat/jdk21-truffle24-x branch 2 times, most recently from 27bc91d to fa763c8 Compare January 28, 2025 23:55
- feat: support for jvm21+ toolchain
- feat: support for gradle toolchains
- feat: pass `-PnativeArch=native` to build with `-march=native`
- feat: `-Os` optimization for native builds
- test: multi-jdk testing support
- fix: remove mrjar classes at >jvm17 from fatjars
- fix: use jdk21 to run the tests (needed for `Unsafe.ensureInitialized`)
- fix: truffle svm dependency is required after graalvm `24.0.0`
- fix: warnings for gvm flag usage, renamed truffle svm macro
- fix: build with `--add-modules=jdk.unsupported` where needed
- fix: don't use `gu` tool for modern graalvm versions
- chore: buildinfo changes for JVM targets, toolchains
- chore: enforce testing at exactly jdk21
- chore: enforce build tooling at jdk21+
- chore: bump graalvm/truffle libs → `24.1.2`
- chore: toolchains for `buildSrc`

Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
- chore: update to jdk21 in circle jobs
- chore: re-gen circle jobs

Signed-off-by: Sam Gammon <sam@elide.dev>
- fix: don't exclude svm classes from `cli` jar

SVM (SubstrateVM) compile configuration classes
must be included within the `cli` jar to prevent
downstream `native-image` builds from failing.

- fix: include svm exclusions in fatjar config

Fat JARs cannot be used with `native-image`, so
these classes can still safely be excluded here.

Fixes and closes apple#907
Cherry-picked from apple#914

Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon sgammon force-pushed the feat/jdk21-truffle24-x branch from 69e7973 to ed7abb1 Compare January 29, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant