fix: binary type options #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cocoa-xu, I would prefer to not have the mock tests. Ideally, we would try to get one of the builtin databases (duckdb or sqlite3) and test those APIs directly against them, using one of their many options. Do you think this would be possible? |
This reverts commit 562f502.
|
Okay, I think that should be good too. (I was trying to test some implementation but I wasn't quite sure which SQL queries can produce correspond responses hence I added the mocked ones) |
josevalim
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that we need to use
ErlNifBinarywhen setting binary type options. It saves one copy in thestd::stringand also fixes a bug I found when doing some mock tests.I also added these mock tests in this PR, and they will only run when env var
CIexists or is explicitly included (although I'm not sure if we would want these mock tests in this repo). If we don't need these mock tests in the repo I'll remove the corresponding commit. :)