Use …
to incidate there are hidden rows
#1064
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In discord we chatted about using
…
to indicate that there are hidden rows. This PR does that, but I ended up doing a few other things while I was at it.This PR does:
…
to indicate there are hidden rows. Includes a new optionlimit_dots: :bottom | :split
to specify how to do this.TableRex.render!/2
. This gives you a little more flexibility in case you don't like the defaults.Example
Before:
After:
Row separators
The row separators have bothered me for a while. They effectively double the vertical size of the printed dataframe. But they're only necessary when there are multi-line cells.
With this PR, I choose to only include row separators when there's a "composite" dtype (list or struct). IMO this should cover most cases where the extra row separator is beneficial in a predictable way.
Another way to do it is to detect the presence of multi-line cells. There are tradeoffs to both approaches.
I'm also happy to scale this PR back to just the
…
part.