Support ellipsis in doctest exceptions #14233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Jan 28, 2025
| raise ArgumentError, message: "Unexpected:\n#{inspect(arg)}" | ||
| end | ||
| end | ||
| |> ExUnit.BeamHelpers.write_beam() |
There was a problem hiding this comment.
Should we add a test when the error message itself has "..." at the end?
There was a problem hiding this comment.
Added in 468bfbc.
I'm not sure it's too useful since technically if we allow for anything then there's little reason for ... not to pass, but it doesn't cost much to have it so I'm fine either way.
josevalim
reviewed
Jan 28, 2025
lib/ex_unit/lib/ex_unit/doc_test.ex
Outdated
Comment on lines
607
to
608
| case String.replace_suffix(expected, "...", "") do | ||
| ^expected -> false |
There was a problem hiding this comment.
This seems to be an expensive check to verify if the string has ... or not. My suggestion is to use String.ends_with? and then binary_slice.
josevalim
approved these changes
Jan 28, 2025
josevalim
reviewed
Jan 28, 2025
josevalim
approved these changes
Jan 28, 2025
Co-authored-by: José Valim <jose.valim@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #14210