Trimap #236
Merged
Trimap #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Mar 5, 2024
josevalim
reviewed
Mar 5, 2024
| @@ -0,0 +1,478 @@ | |||
| defmodule Scholar.Manifold.Trimap do | |||
| @moduledoc """ | |||
| TriMap: Large-scale Dimensionality Reduction Using Triplets. | |||
There was a problem hiding this comment.
It you can add a bit more words, especially about how it compares with other techniques in Scholar (such as kNN), both in terms of performance and results, it would be excellent. :)
josevalim
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Looks great. Just some minor comments.
I believe you can now merge/rebase this on main (or maybe it will be easier to start a new branch and cherry pick your trimap on top).
After merged, let's please writing a document comparing our manifolds, in performance and results. :)
Co-authored-by: José Valim <jose.valim@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.