perf: silence more notifications

packages/graph/src/-private/-utils.ts

@@ -143,7 +143,7 @@ export function removeIdentifierCompletelyFromRelationship(
       // we shouldn't be notifying here though, figure out where
       // a notification was missed elsewhere.
       if (!silenceNotifications) {
-        notifyChange(graph, relationship.identifier, relationship.definition.key);
+        notifyChange(graph, relationship);
       }
     }
   } else if (isHasMany(relationship)) {
@@ -164,7 +164,7 @@ export function removeIdentifierCompletelyFromRelationship(
         // we shouldn't be notifying here though, figure out where
         // a notification was missed elsewhere.
         if (!silenceNotifications) {
-          notifyChange(graph, relationship.identifier, relationship.definition.key);
+          notifyChange(graph, relationship);
         }
       }
     }
@@ -174,8 +174,14 @@ export function removeIdentifierCompletelyFromRelationship(
   }
 }
 
-// TODO add silencing at the graph level
-export function notifyChange(graph: Graph, identifier: StableRecordIdentifier, key: string) {
+export function notifyChange(graph: Graph, relationship: CollectionEdge | ResourceEdge): void {
+  if (!relationship.accessed) {
+    return;
+  }
+
+  const identifier = relationship.identifier;
+  const key = relationship.definition.key;
+
   if (identifier === graph._removing) {
     if (LOG_GRAPH) {
       // eslint-disable-next-line no-console

packages/graph/src/-private/edges/collection.ts

@@ -24,6 +24,7 @@ export interface CollectionEdge {
   localState: StableRecordIdentifier[] | null;
   isDirty: boolean;
   transactionRef: number;
+  accessed: boolean;
 
   _diff?: {
     add: Set<StableRecordIdentifier>;
@@ -47,11 +48,13 @@ export function createCollectionEdge(definition: UpgradedMeta, identifier: Stabl
     localState: null,
     isDirty: true,
     transactionRef: 0,
+    accessed: false,
     _diff: undefined,
   };
 }
 
 export function legacyGetCollectionRelationshipData(source: CollectionEdge): CollectionRelationship {
+  source.accessed = true;
   const payload: CollectionRelationship = {};
 
   if (source.state.hasReceivedData) {

packages/graph/src/-private/edges/resource.ts

@@ -23,6 +23,7 @@ export interface ResourceEdge {
   meta: Meta | null;
   links: Links | PaginationLinks | null;
   transactionRef: number;
+  accessed: boolean;
 }
 
 export function createResourceEdge(definition: UpgradedMeta, identifier: StableRecordIdentifier): ResourceEdge {
@@ -35,10 +36,12 @@ export function createResourceEdge(definition: UpgradedMeta, identifier: StableR
     remoteState: null,
     meta: null,
     links: null,
+    accessed: false,
   };
 }
 
 export function legacyGetResourceRelationshipData(source: ResourceEdge): ResourceRelationship {
+  source.accessed = true;
   let data: StableRecordIdentifier | null | undefined;
   const payload: ResourceRelationship = {};
   if (source.localState) {

packages/graph/src/-private/graph.ts

@@ -559,7 +559,7 @@ export class Graph {
     this._willSyncLocal = false;
     const updated = this._updatedRelationships;
     this._updatedRelationships = new Set();
-    updated.forEach((rel) => notifyChange(this, rel.identifier, rel.definition.key));
+    updated.forEach((rel) => notifyChange(this, rel));
   }
 
   destroy() {
@@ -641,7 +641,7 @@ function destroyRelationship(graph: Graph, rel: GraphEdge, silenceNotifications?
     // leave the ui relationship populated since the record is destroyed and
     // internally we've fully cleaned up.
     if (!rel.definition.isAsync && !silenceNotifications) {
-      /*#__NOINLINE__*/ notifyChange(graph, rel.identifier, rel.definition.key);
+      /*#__NOINLINE__*/ notifyChange(graph, rel);
     }
   }
 }
@@ -713,7 +713,7 @@ function removeDematerializedInverse(
     }
 
     if (!silenceNotifications) {
-      notifyChange(graph, relationship.identifier, relationship.definition.key);
+      notifyChange(graph, relationship);
     }
   } else {
     if (!relationship.definition.isAsync || (inverseIdentifier && isNew(inverseIdentifier))) {
@@ -728,7 +728,7 @@ function removeDematerializedInverse(
     }
 
     if (!silenceNotifications) {
-      notifyChange(graph, relationship.identifier, relationship.definition.key);
+      notifyChange(graph, relationship);
     }
   }
 }
@@ -753,7 +753,7 @@ function removeCompletelyFromInverse(graph: Graph, relationship: GraphEdge) {
     if (!relationship.definition.isAsync) {
       clearRelationship(relationship);
 
-      notifyChange(graph, relationship.identifier, relationship.definition.key);
+      notifyChange(graph, relationship);
     }
   } else {
     relationship.remoteMembers.clear();

packages/graph/src/-private/operations/add-to-related-records.ts

@@ -27,7 +27,7 @@ export default function addToRelatedRecords(graph: Graph, op: AddToRelatedRecord
     addRelatedRecord(graph, relationship, record, value, index, isRemote);
   }
 
-  notifyChange(graph, relationship.identifier, relationship.definition.key);
+  notifyChange(graph, relationship);
 }
 
 function addRelatedRecord(

packages/graph/src/-private/operations/merge-identifier.ts

@@ -40,7 +40,7 @@ function mergeBelongsTo(graph: Graph, rel: ResourceEdge, op: MergeOperation): vo
   }
   if (rel.localState === op.record) {
     rel.localState = op.value;
-    notifyChange(graph, rel.identifier, rel.definition.key);
+    notifyChange(graph, rel);
   }
 }
 
@@ -63,7 +63,7 @@ function mergeHasMany(graph: Graph, rel: CollectionEdge, op: MergeOperation): vo
     rel.isDirty = true;
   }
   if (rel.isDirty) {
-    notifyChange(graph, rel.identifier, rel.definition.key);
+    notifyChange(graph, rel);
   }
 }
 

packages/graph/src/-private/operations/remove-from-related-records.ts

@@ -30,7 +30,7 @@ export default function removeFromRelatedRecords(graph: Graph, op: RemoveFromRel
   } else {
     removeRelatedRecord(graph, relationship, record, value, isRemote);
   }
-  notifyChange(graph, relationship.identifier, relationship.definition.key);
+  notifyChange(graph, relationship);
 }
 
 function removeRelatedRecord(

packages/graph/src/-private/operations/replace-related-record.ts

@@ -107,7 +107,7 @@ export default function replaceRelatedRecord(graph: Graph, op: ReplaceRelatedRec
             }
           );
 
-          notifyChange(graph, relationship.identifier, relationship.definition.key);
+          notifyChange(graph, relationship);
         }
       }
     }
@@ -156,7 +156,7 @@ export default function replaceRelatedRecord(graph: Graph, op: ReplaceRelatedRec
     // and we can safely sync the new remoteState to local
     if (localState !== remoteState && localState === existingState) {
       relationship.localState = remoteState;
-      notifyChange(graph, relationship.identifier, relationship.definition.key);
+      notifyChange(graph, relationship);
       // But when localState does not match the new remoteState and
       // and localState !== existingState then we know we have a local mutation
       // that has not been persisted yet.
@@ -186,10 +186,10 @@ export default function replaceRelatedRecord(graph: Graph, op: ReplaceRelatedRec
           }
         );
 
-        notifyChange(graph, relationship.identifier, relationship.definition.key);
+        notifyChange(graph, relationship);
       }
     }
   } else {
-    notifyChange(graph, relationship.identifier, relationship.definition.key);
+    notifyChange(graph, relationship);
   }
 }

packages/graph/src/-private/operations/replace-related-records.ts

@@ -164,7 +164,7 @@ function replaceRelatedRecordsLocal(graph: Graph, op: ReplaceRelatedRecordsOpera
   // because ?? may need to recalculate.
   // otherwise we only notify if we are dirty and were not already dirty before
   if (isMaybeFirstUpdate || (becameDirty && !wasDirty)) {
-    notifyChange(graph, op.record, op.field);
+    notifyChange(graph, relationship);
   }
 }
 
@@ -352,7 +352,8 @@ export function addToInverse(
         removeFromInverse(graph, relationship.localState, relationship.definition.inverseKey, identifier, isRemote);
       }
       relationship.localState = value;
-      notifyChange(graph, identifier, key);
+
+      notifyChange(graph, relationship);
     }
   } else if (isHasMany(relationship)) {
     if (isRemote) {
@@ -375,7 +376,7 @@ export function addToInverse(
       }
     } else {
       if (_addLocal(graph, identifier, relationship, value, null)) {
-        notifyChange(graph, identifier, key);
+        notifyChange(graph, relationship);
       }
     }
   } else {
@@ -401,7 +402,7 @@ export function notifyInverseOfPotentialMaterialization(
 ) {
   const relationship = graph.get(identifier, key);
   if (isHasMany(relationship) && isRemote && relationship.remoteMembers.has(value)) {
-    notifyChange(graph, identifier, key);
+    notifyChange(graph, relationship);
   }
 }
 
@@ -423,17 +424,17 @@ export function removeFromInverse(
     if (relationship.localState === value) {
       relationship.localState = null;
 
-      notifyChange(graph, identifier, key);
+      notifyChange(graph, relationship);
     }
   } else if (isHasMany(relationship)) {
     if (isRemote) {
       graph._addToTransaction(relationship);
       if (_removeRemote(relationship, value)) {
-        notifyChange(graph, identifier, key);
+        notifyChange(graph, relationship);
       }
     } else {
       if (_removeLocal(relationship, value)) {
-        notifyChange(graph, identifier, key);
+        notifyChange(graph, relationship);
       }
     }
   } else {
@@ -449,10 +450,7 @@ export function removeFromInverse(
 }
 
 function flushCanonical(graph: Graph, rel: CollectionEdge) {
-  // if this relationship does not have localState then
-  // we have never computed it before, meaning it has no
-  // possible subscribers.
-  if (rel.localState !== null) {
+  if (rel.accessed) {
     graph._scheduleLocalSync(rel);
   }
 }

packages/graph/src/-private/operations/update-relationship.ts

@@ -157,7 +157,7 @@ export default function updateRelationshipOperation(graph: Graph, op: UpdateRela
     ) {
       relationship.state.isStale = true;
 
-      notifyChange(graph, relationship.identifier, relationship.definition.key);
+      notifyChange(graph, relationship);
     } else {
       relationship.state.isStale = false;
     }