Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing log attachment count bug #166

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Fixing log attachment count bug #166

merged 2 commits into from
Jan 28, 2025

Conversation

NachoEmbrace
Copy link
Contributor

@NachoEmbrace NachoEmbrace commented Jan 27, 2025 •
edited
Loading

  • The actual attachment limit was 4 per session (instead of 5) due to this bug.
  • Also removing the attachment size parameter since it wont be used.

@NachoEmbrace NachoEmbrace requested a review from a team as a code owner January 27, 2025 17:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

Warnings
⚠️ No CHANGELOG entry added.

Generated by 🚫 Danger Swift against 206a4a0

@NachoEmbrace NachoEmbrace merged commit e72a2dd into main Jan 28, 2025
6 of 8 checks passed
@NachoEmbrace NachoEmbrace deleted the log_attachment_limit_fix branch January 28, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArielDemarco ArielDemarco ArielDemarco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NachoEmbrace @ArielDemarco