Refactor Proxies using NSProxy and Objc #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Generated by 🚫 Danger Swift against 71a4d58 |
ArielDemarco
force-pushed
the
fix-proxies
branch
from
71a4d58 to
a32a1b0
Compare
ferdraghi
reviewed
Feb 11, 2025
ferdraghi
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We discovered several issues when relying on manually created proxies using
NSObjectand overriding certain methods, such asresponds(to:)andforwardingTarget(for:). While most of these issues can be (and were) resolved, we encountered problems with optional protocols being called from Swift, which could lead to unexpected behavior.Based on this and other internal discussions, we decided to move forward with a proper proxy by inheriting from
NSProxy, allowing us to fully control the messaging chain.