Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests from previous PRs #181

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Fix failing tests from previous PRs #181

merged 2 commits into from
Feb 18, 2025

Conversation

ArielDemarco
Copy link
Collaborator

@ArielDemarco ArielDemarco commented Feb 17, 2025

Overview

Some tests were failing because we were unswizzling in the wrong order. This caused URLSession to become polluted, leading to issues under certain conditions

@ArielDemarco ArielDemarco requested a review from a team as a code owner February 17, 2025 16:23
Copy link

github-actions bot commented Feb 17, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

github-actions bot commented Feb 17, 2025

Warnings
⚠️ Please provide a description for the changes in this Pull Request.

Generated by 🚫 Danger Swift against 0348557

@ArielDemarco ArielDemarco merged commit e1d6bc6 into main Feb 18, 2025
6 of 7 checks passed
@ArielDemarco ArielDemarco deleted the fix-flaky-tests branch February 18, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants