Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compose click event note #220

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Add compose click event note #220

merged 2 commits into from
Feb 25, 2025

Conversation

fractalwrench
Copy link
Contributor

Goal

Adds a note that compose click events may effect performance.

@fractalwrench fractalwrench requested a review from a team as a code owner February 24, 2025 10:37
Copy link

github-actions bot commented Feb 24, 2025

Summary

Status Count
🔍 Total 313
✅ Successful 267
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 46
❓ Unknown 0
🚫 Errors 0
Full Github Actions output

Copy link
Contributor

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bidetofevil
Copy link
Contributor

Added a suggestion to be more specific about when the perf penalty occurs

Co-authored-by: Hanson Ho <hanson.ho@embrace.io>
@fractalwrench fractalwrench merged commit c410cdf into main Feb 25, 2025
3 checks passed
@fractalwrench fractalwrench deleted the update-compose-docs branch February 25, 2025 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants