Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Data-Marshaling-and-Transmission.md #233

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Conversation

eliabsisay
Copy link
Contributor

updated page description and formatting

Checklist before you pull:

  • Double-check that any changes fit the Embrace Docs Style Guide.
  • Please ensure that there is no customer-identifying information in text or images.
  • Please ensure there is no consumer PII in text or images.
  • If you renamed any pages then perhaps you likely want to add a redirect from old to new URL so that we don't end up with broken links. You can do this by adding a pair of to/from values in docusaurus.config.js under @docusaurus/plugin-client-redirects

updated page description and formatting
Copy link

github-actions bot commented Mar 5, 2025

Summary

Status Count
🔍 Total 313
✅ Successful 267
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 46
❓ Unknown 0
🚫 Errors 0
Full Github Actions output

@@ -1,12 +1,13 @@
---
title: Data Marshaling and Transmission
sidebar_position: 11
description: How about keeping it simple with something like "How Embrace SDKs Transfer Data from Devices to Our Servers
description: How Embrace SDKs Transfer Data from Devices to Our Servers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it in the style guide to capitialize a description like a title?

Copy link
Contributor

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Small comment about the description but not blocking

@eliabsisay eliabsisay merged commit ecef000 into main Mar 5, 2025
3 checks passed
@eliabsisay eliabsisay deleted the eliabsisay-patch-2 branch March 5, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants