Skip to content

Commit

Permalink
main_panel: Remove “Test” button
Browse files Browse the repository at this point in the history
This button was connected to a callback which didn't do anything,
as an artefact from earlier experimentation.

By removing it we can also remove the VBox that contained only the
button and the MarginContainer, simplifying the control hierarchy a bit.
  • Loading branch information
wjt committed Jun 14, 2024
1 parent 62e90bf commit 7d18916
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 23 deletions.
4 changes: 0 additions & 4 deletions addons/block_code/ui/main_panel.gd
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,6 @@ func _ready():
block_code_tab = eia.Utils.find_child_by_name(eia.context_switcher, "Block Code")


func _on_button_pressed():
pass


func switch_script(block_code_node: BlockCode):
var bsd = block_code_node.bsd
if bsd:
Expand Down
28 changes: 9 additions & 19 deletions addons/block_code/ui/main_panel.tscn
Original file line number Diff line number Diff line change
Expand Up @@ -16,52 +16,42 @@ size_flags_horizontal = 3
size_flags_vertical = 3
script = ExtResource("1_u0xju")

[node name="VBoxContainer" type="VBoxContainer" parent="."]
layout_mode = 2

[node name="Button" type="Button" parent="VBoxContainer"]
layout_mode = 2
size_flags_horizontal = 0
text = "Test"

[node name="MarginContainer" type="MarginContainer" parent="VBoxContainer"]
[node name="MarginContainer" type="MarginContainer" parent="."]
layout_mode = 2
size_flags_vertical = 3

[node name="HBoxContainer" type="HBoxContainer" parent="VBoxContainer/MarginContainer"]
[node name="HBoxContainer" type="HBoxContainer" parent="MarginContainer"]
layout_mode = 2
size_flags_vertical = 3

[node name="ScriptVBox" type="VBoxContainer" parent="VBoxContainer/MarginContainer/HBoxContainer"]
[node name="ScriptVBox" type="VBoxContainer" parent="MarginContainer/HBoxContainer"]
layout_mode = 2
size_flags_horizontal = 3

[node name="TitleBar" parent="VBoxContainer/MarginContainer/HBoxContainer/ScriptVBox" instance=ExtResource("2_k54yf")]
[node name="TitleBar" parent="MarginContainer/HBoxContainer/ScriptVBox" instance=ExtResource("2_k54yf")]
unique_name_in_owner = true
layout_mode = 2

[node name="MarginContainer" type="MarginContainer" parent="VBoxContainer/MarginContainer/HBoxContainer/ScriptVBox"]
[node name="MarginContainer" type="MarginContainer" parent="MarginContainer/HBoxContainer/ScriptVBox"]
layout_mode = 2
size_flags_vertical = 3

[node name="HBoxContainer" type="HBoxContainer" parent="VBoxContainer/MarginContainer/HBoxContainer/ScriptVBox/MarginContainer"]
[node name="HBoxContainer" type="HBoxContainer" parent="MarginContainer/HBoxContainer/ScriptVBox/MarginContainer"]
layout_mode = 2
size_flags_horizontal = 3
size_flags_vertical = 3

[node name="Picker" parent="VBoxContainer/MarginContainer/HBoxContainer/ScriptVBox/MarginContainer/HBoxContainer" instance=ExtResource("2_hv5f3")]
[node name="Picker" parent="MarginContainer/HBoxContainer/ScriptVBox/MarginContainer/HBoxContainer" instance=ExtResource("2_hv5f3")]
unique_name_in_owner = true
layout_mode = 2

[node name="NodeBlockCanvas" parent="VBoxContainer/MarginContainer/HBoxContainer/ScriptVBox/MarginContainer/HBoxContainer" instance=ExtResource("3_ml5y3")]
[node name="NodeBlockCanvas" parent="MarginContainer/HBoxContainer/ScriptVBox/MarginContainer/HBoxContainer" instance=ExtResource("3_ml5y3")]
unique_name_in_owner = true
layout_mode = 2

[node name="DragManager" parent="VBoxContainer/MarginContainer/HBoxContainer/ScriptVBox/MarginContainer" instance=ExtResource("4_yijtu")]
[node name="DragManager" parent="MarginContainer/HBoxContainer/ScriptVBox/MarginContainer" instance=ExtResource("4_yijtu")]
unique_name_in_owner = true
layout_mode = 2
mouse_filter = 2
picker_path = NodePath("../HBoxContainer/Picker")
block_canvas_path = NodePath("../HBoxContainer/NodeBlockCanvas")

[connection signal="pressed" from="VBoxContainer/Button" to="." method="_on_button_pressed"]

0 comments on commit 7d18916

Please sign in to comment.