Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom category icons, tooltips, and removed labels #270

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

DoomTas3r
Copy link
Contributor

@DoomTas3r DoomTas3r commented Oct 13, 2024

Removes category labels and subcategories, and adds tooltips and custom icons. Loading the icons was not optimized

Based on the idea #131 (comment)

image

@DoomTas3r DoomTas3r marked this pull request as ready for review October 13, 2024 22:06
@DoomTas3r DoomTas3r marked this pull request as draft October 13, 2024 22:13
@DoomTas3r DoomTas3r marked this pull request as ready for review October 13, 2024 22:16
@manuq
Copy link
Contributor

manuq commented Oct 17, 2024

Hi @DoomTas3r . This is nice, thanks for working on it. I think we can come up with better icons for the different categories later. Would you like to cleanup your commits so we can metge? Basically squash the "Fixes" commits and come with a few reviewable commits. Please let me know if you need help with cleaning up.

@DoomTas3r DoomTas3r marked this pull request as draft October 17, 2024 19:30
@DoomTas3r
Copy link
Contributor Author

I think I understand how squash works now. I will squash the commits in other pull requests

@DoomTas3r DoomTas3r marked this pull request as ready for review October 17, 2024 23:45
@DoomTas3r DoomTas3r changed the title Category icons and tooltip Category icons, tooltips, and shorter labels Oct 17, 2024
@DoomTas3r DoomTas3r marked this pull request as draft November 19, 2024 16:08
@DoomTas3r DoomTas3r changed the title Category icons, tooltips, and shorter labels Custom category icons, tooltips, and removed labels Jan 26, 2025
@DoomTas3r DoomTas3r marked this pull request as ready for review January 26, 2025 02:41
@cassidyjames cassidyjames requested a review from manuq January 30, 2025 18:59
@cassidyjames
Copy link
Member

On HiDPI (2× scaling) the icons look tiny; is there a way to make them scale with the UI?
image

@DoomTas3r
Copy link
Contributor Author

@cassidyjames I changed the import files so that the icons scale with the editor. How do they look now?

@manuq
Copy link
Contributor

manuq commented Feb 3, 2025

@DoomTas3r this is looking very nice! By the way, I don't have an HiDPI display.
Captura desde 2025-02-03 12-20-20

Copy link
Member

@cassidyjames cassidyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI-wise this looks and feels great to me. Nice work

image

I've confirmed the icons now scale correctly on HiDPI. I was going to point out that it looks like the category labels don't scale, but they don't in main, either…

image

I'll file a separate issue for that. :)

@manuq
Copy link
Contributor

manuq commented Feb 5, 2025

@DoomTas3r would you like to cleanup the PR? The second commit undo things done by the first one. For example I see icons added and then removed. So you should squash them into one and provide a descriptive commit message. Then we can start reviewing!

@@ -24,130 +24,156 @@ const BUILTIN_CATEGORIES_PROPS: Dictionary = {
{
"color": Color("ec3b59"),
"order": 10,
"icon": "lifecycle",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below in the PR you do this for the button tooltip text:

_button.tooltip_text = tr(category.name.get_slice(" |", 0))

So I think it's better to do the same thing instead of introducing a new "icon" key in this constant. If you want to keep the SVG files lowercase, you can use to_lower()

Adds custom icons for the category picker and removes the labels and subcategories
@DoomTas3r
Copy link
Contributor Author

@manuq Alright, it's all cleaned up!

@DoomTas3r DoomTas3r requested a review from manuq February 5, 2025 16:17
@manuq manuq merged commit 9d10248 into endlessm:main Feb 6, 2025
3 checks passed
@DoomTas3r DoomTas3r deleted the category-icons branch February 6, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants