-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom category icons, tooltips, and removed labels #270
Conversation
Hi @DoomTas3r . This is nice, thanks for working on it. I think we can come up with better icons for the different categories later. Would you like to cleanup your commits so we can metge? Basically squash the "Fixes" commits and come with a few reviewable commits. Please let me know if you need help with cleaning up. |
f68aa25
to
3847613
Compare
I think I understand how squash works now. I will squash the commits in other pull requests |
3eea2e9
to
c3e294f
Compare
09c4e4d
to
28afa4e
Compare
@cassidyjames I changed the import files so that the icons scale with the editor. How do they look now? |
28afa4e
to
fd95141
Compare
@DoomTas3r this is looking very nice! By the way, I don't have an HiDPI display. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DoomTas3r would you like to cleanup the PR? The second commit undo things done by the first one. For example I see icons added and then removed. So you should squash them into one and provide a descriptive commit message. Then we can start reviewing! |
addons/block_code/ui/constants.gd
Outdated
@@ -24,130 +24,156 @@ const BUILTIN_CATEGORIES_PROPS: Dictionary = { | |||
{ | |||
"color": Color("ec3b59"), | |||
"order": 10, | |||
"icon": "lifecycle", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below in the PR you do this for the button tooltip text:
_button.tooltip_text = tr(category.name.get_slice(" |", 0))
So I think it's better to do the same thing instead of introducing a new "icon" key in this constant. If you want to keep the SVG files lowercase, you can use to_lower()
Adds custom icons for the category picker and removes the labels and subcategories
04c6d9a
to
59de3cc
Compare
@manuq Alright, it's all cleaned up! |
Removes category labels and subcategories, and adds tooltips and custom icons. Loading the icons was not optimized
Based on the idea #131 (comment)