Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace run-with-testrpc with ganache #696

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

JGiter
Copy link
Collaborator

@JGiter JGiter commented Jun 9, 2023

Description

run-with-testrpc is not maintained for 4 years already, which is possilbe reason of https://github.com/energywebfoundation/iam-client-lib/actions/runs/5219187364/jobs/9420739666?pr=695
As it turned out the real reason of not detecting of network is localhost in rpc url. It should be 127.0.0.1. Not crear why or how this changed. ethers documentation provides example of creating JsonRpcProvider with http://localhost:8545 url
Even if problem was not caused by run-with-testrpc it still seems usefull to replace it

Contributor checklist

  • Breaking changes - check for any existing interfaces changes that are not backward compatible, removed method etc.
  • Documentation - document your code, add comments for method, remember to check if auto generated docs were updated.
  • Tests - add new or updated existed test for changes you made.
  • Migration guide - add migration guide for every breaking change.
  • Configuration correctness - check that any configuration changes are correct ex. default URLs, chain ids, smart contract verification on Volta explorer or EWC explorer.

@JGiter JGiter force-pushed the replace_run-with-testrpc_with_ganache branch 6 times, most recently from 10acfb2 to e12e1b0 Compare June 9, 2023 11:00
@JGiter JGiter force-pushed the replace_run-with-testrpc_with_ganache branch from e12e1b0 to 1316301 Compare June 9, 2023 11:02
@JGiter JGiter force-pushed the enable_ci_tests branch from 7201a9a to 326ef05 Compare June 9, 2023 11:26
Base automatically changed from enable_ci_tests to develop June 9, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant