Skip to content

Commit

Permalink
f2fs: remove blk_plugging in block_operations
Browse files Browse the repository at this point in the history
blk_plugging doesn't seem to give any benefit.

Change-Id: Ia187efe2617823492dabc4b1f77e0fae43c68fab
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Git-commit: 1f5f11a3c41e2b23288b2769435a00f74e02496b
Git-repo: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/
Signed-off-by: Sahitya Tummala <stummala@codeaurora.org>
Signed-off-by: engstk <eng.stk@sapo.pt>
  • Loading branch information
Jaegeuk Kim authored and engstk committed Oct 9, 2020
1 parent 8482442 commit 400c3df
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions fs/f2fs/checkpoint.c
Original file line number Diff line number Diff line change
Expand Up @@ -1167,11 +1167,8 @@ static int block_operations(struct f2fs_sb_info *sbi)
.nr_to_write = LONG_MAX,
.for_reclaim = 0,
};
struct blk_plug plug;
int err = 0, cnt = 0;

blk_start_plug(&plug);

/*
* Let's flush inline_data in dirty node pages.
*/
Expand Down Expand Up @@ -1204,7 +1201,7 @@ static int block_operations(struct f2fs_sb_info *sbi)
f2fs_unlock_all(sbi);
err = f2fs_sync_dirty_inodes(sbi, DIR_INODE);
if (err)
goto out;
return err;
cond_resched();
goto retry_flush_quotas;
}
Expand All @@ -1220,7 +1217,7 @@ static int block_operations(struct f2fs_sb_info *sbi)
f2fs_unlock_all(sbi);
err = f2fs_sync_inode_meta(sbi);
if (err)
goto out;
return err;
cond_resched();
goto retry_flush_quotas;
}
Expand All @@ -1236,7 +1233,7 @@ static int block_operations(struct f2fs_sb_info *sbi)
if (err) {
up_write(&sbi->node_change);
f2fs_unlock_all(sbi);
goto out;
return err;
}
cond_resched();
goto retry_flush_nodes;
Expand All @@ -1248,8 +1245,6 @@ static int block_operations(struct f2fs_sb_info *sbi)
*/
__prepare_cp_block(sbi);
up_write(&sbi->node_change);
out:
blk_finish_plug(&plug);
return err;
}

Expand Down

0 comments on commit 400c3df

Please sign in to comment.