-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory game #82
Memory game #82
Conversation
75a06ad
to
85a6707
Compare
f2b475d
to
e486a78
Compare
e486a78
to
0433371
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
<Button className={classes.btnPublish} onClick={getDataUrlCanvas}> | ||
PUBLISH | ||
</Button> | ||
<Button className={classes.btnPublish}>PUBLISH</Button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing translate
|
||
import Card from './Card' | ||
|
||
import styles from './styles' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tetogomez this should be just one block
import Card from './Card'
import styles from './styles'
|
||
return ( | ||
<header> | ||
<div className={classes.title}>React-Memory</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this should say "gGoods Memory" and use translations
reset | ||
</button> | ||
</div> | ||
<div className={classes.title}>Attempts: {attempts}</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing translate
resetGame() | ||
}, []) | ||
|
||
// console.log({ deck }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tetogomez remove this line
cover: { | ||
width: 125, | ||
height: 125, | ||
backgroundColor: '#a5a1a4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tetogomez please try to avoid static colors
Add memory game
What does this PR do?
Steps to test
make run
create template
sidebar menu optionCheckList