Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory game #82

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Memory game #82

merged 2 commits into from
Mar 25, 2021

Conversation

tetogomez
Copy link
Member

Add memory game

What does this PR do?

Steps to test

  1. run make run
  2. go to localhost:3000
  3. select create template sidebar menu option

CheckList

  • [] Follow proper Markdown format
  • [] The content is adequate
  • [] The content is available in both english and spanish
  • [] I Ran a spell check

@tetogomez tetogomez added Dont Merge Not Ready for merge - Only for review WIP Work In Progress labels Mar 25, 2021
@tetogomez tetogomez force-pushed the feature/memory-game branch from 75a06ad to 85a6707 Compare March 25, 2021 05:56
@tetogomez tetogomez removed Dont Merge Not Ready for merge - Only for review WIP Work In Progress labels Mar 25, 2021
@tetogomez tetogomez force-pushed the feature/memory-game branch from f2b475d to e486a78 Compare March 25, 2021 20:14
@tetogomez tetogomez force-pushed the feature/memory-game branch from e486a78 to 0433371 Compare March 25, 2021 20:40
Copy link
Member

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit 846af0b into main Mar 25, 2021
@xavier506 xavier506 deleted the feature/memory-game branch March 25, 2021 22:58
<Button className={classes.btnPublish} onClick={getDataUrlCanvas}>
PUBLISH
</Button>
<Button className={classes.btnPublish}>PUBLISH</Button>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing translate


import Card from './Card'

import styles from './styles'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tetogomez this should be just one block

import Card from './Card'
import styles from './styles'


return (
<header>
<div className={classes.title}>React-Memory</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this should say "gGoods Memory" and use translations

reset
</button>
</div>
<div className={classes.title}>Attempts: {attempts}</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing translate

resetGame()
}, [])

// console.log({ deck })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tetogomez remove this line

cover: {
width: 125,
height: 125,
backgroundColor: '#a5a1a4'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tetogomez please try to avoid static colors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory Game
4 participants