Add apply_discount_factor to gas_parameters #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elmato
force-pushed
the
elmato/discount-factor
branch
from
72c15e0 to
032abf0
Compare
Closed
yarkinwho
requested changes
Jan 14, 2025
lib/evmone/execution_state.hpp
Outdated
| speculative_cpu_gas_consumed_ = std::max(y, 0l); | ||
| cpu_gas_refund_ = std::max(-y, 0l); | ||
| speculative_cpu_gas_consumed_ = std::max(y, decltype(y){0}); | ||
| cpu_gas_refund_ = std::max(-y, decltype(y){0}); |
There was a problem hiding this comment.
is it possible to eliminate the use of auto and decltype here? it seems a little bit dangerous to me to use things like auto and decltype in the scenarios that have the risk of overflow/underflow.
There was a problem hiding this comment.
I wonder if change the auto above as well can help fixing this?
yarkinwho
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.