Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wps issue #132

Merged
merged 10 commits into from
Dec 20, 2024
Merged

Fixed wps issue #132

merged 10 commits into from
Dec 20, 2024

Conversation

jamesli124
Copy link
Collaborator

@jamesli124 jamesli124 commented Dec 20, 2024

[0.10.2] - 2024-12-19

Fixed

  • changed default args for wps would lead to errors. Now wps defaults to
    LWPS fragment lengths (120-180nt).

Changed

  • made finaeltoolkit.utils.typing public. This is a module containing some
    useful type aliases
  • minor formatting and typing changes
  • renamed fraction_low and fraction_high to min_length and max_length
    for .utils.frag_array and .frag.wps. wps retains the deprecated arg names
    but issues a warning.

jamesli124 and others added 10 commits December 19, 2024 13:37
    - rename `contig` to `chrom`
    - Include `chrom_size` arg for size of `chrom`. This ensures that in the rare case the extra margin from which frags are fetched exceeds the size of a chromosome, no error occurs.
    - In `multi_wps`, chrom sizes are read from `chrom_sizes` and fed to subprocesses.
    - Defaults for `wps` command changed to be more sensible.
Copy link
Collaborator

@ravibandaru-lab ravibandaru-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wowwww

@ravibandaru-lab ravibandaru-lab merged commit 90df4a4 into main Dec 20, 2024
8 checks passed
@ravibandaru-lab ravibandaru-lab deleted the fix-unaccepted-types branch December 20, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants