Move mean to parameter for negative binomial in DB #380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the mean and any uncertainty around the mean from the summary statistics object to the parameters object in the JSON database (
parameters.json
). This is to consolidate what is considered a parameter or summary statistic in the package (matchingis_epiparameter_params()
), see also #379.The JSON schema is updated to explicitly check if the mean, standard deviation and dispersion are being specified correctly depending on the probability distribution. For normal and negative binomial distributions, these should be specified as parameters, whereas for other distributions, e.g. lognormal, they should be specified as summary statistics.