Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for v0.4.1 release #437

Merged
merged 14 commits into from
Jan 27, 2025
Merged

Updates for v0.4.1 release #437

merged 14 commits into from
Jan 27, 2025

Conversation

joshwlambert
Copy link
Member

This PR makes a range of minor updates to the package to resolve the issues flagged by the CRAN package checks for the precompiled extract-bias.Rmd vignette and the unit test failures on the CRAN M1mac check, incrementing to v0.4.1 for a new patch release on CRAN and GitHub.

Updates include:

  • Converting the extract-bias.Rmd vignette to an article to only be rendered on the pkgdown website and not on CRAN.
  • Skipping the two unit tests for extract_param() for the Weibull distribution due to numerical inconsistency compare to testing locally and on GitHub actions.
  • The NEWS.md is updated.
  • The patch version is incremented.
  • The reverse dependencies are checked (revdepcheck::revdep_check(num_workers = 4) and the revdep/ folder added to the package.
  • cran-comments.md is updated.
  • The precompile.R script is updated for the new file path of the extract-bias vignette and to move the plot files programmatically instead of manually.

@joshwlambert joshwlambert added pkg infrastructure General update tasks relating to the package and not functionality CRAN labels Jan 22, 2025
@joshwlambert
Copy link
Member Author

I've also updated the fig.path in the _extract-bias.Rmd.orig vignette that gets compiled, this enables the figures to be rendered locally with {knitr} and previewed on the website with pkgdown::build_site(), as well as passing the pkgdown.yaml workflow with the untitaker/hyperlink link check.

@joshwlambert joshwlambert merged commit 8c7f95a into main Jan 27, 2025
10 checks passed
@joshwlambert joshwlambert deleted the fix-cran branch January 27, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CRAN pkg infrastructure General update tasks relating to the package and not functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant