feat(rpc/trace): add is_reverted flag to FUNCTION_INVOCATION
#2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version number in the files do not match the actual version though because it has not been updated properly before the release.
An update to the 0.8 OpenRPC spec now requires the `is_reverted` flag for function invocations. Closes: #2496
CHr15F0x
reviewed
Jan 21, 2025
Comment on lines
+496
to
+498
| // Pre-0.13.4 failures in individual calls are not possible -- the whole TX is reverted in | ||
| // that case. | ||
| is_reverted: false, |
There was a problem hiding this comment.
I'm not sure if I get this right but shouldn't there be a TODO here to manage 0.14.0 (ie. the gateway will provide this field)?
There was a problem hiding this comment.
I'm not sure if I get this right but shouldn't there be a TODO here to manage 0.14.0 (ie. the gateway will provide this field)?
Good question. As things stand the gateway can no longer provide traces starting with Starknet 0.13.2. Based on a recent discussion with Starkware it seems that it's not only disabled, they're not even generating those traces.
Whether or not this will ever change is a good question...
CHr15F0x
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from Starknet 0.13.4 panics in calls can be caught and handled by callers, so failure in an individual call does not cause the transaction to fail (and revert) immediately.
To be able to find out which calls have failed an update to the 0.8 OpenRPC spec now requires the
is_revertedflag for function invocations.Closes: #2496