Add draft for parameter config #10095
Draft
+682
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xjules
added
the
release-notes:refactor
CodSpeed Performance ReportMerging #10095 will not alter performanceComparing Summary
|
xjules
force-pushed
the
draft_paramcfg
branch
from
8d7051d to
33ef660
Compare
xjules
commented
Feb 24, 2025
|
|
||
|
|
||
| @dataclass | ||
| class TransUnifSettings: |
There was a problem hiding this comment.
TODO: All distributions should contain LOG10 property
This will be handled directly by the type of distribution.
xjules
commented
Feb 24, 2025
src/ert/config/scalar_parameter.py
Outdated
| if group_name not in transformed_dict: | ||
| transformed_dict[group_name] = {} | ||
| transformed_dict[group_name][param_name] = transformed_value | ||
| # todo log handling when distribution requires it |
There was a problem hiding this comment.
TODO: here is also the place that we need to handle template_file / output_file!
There was a problem hiding this comment.
First draft of the treatment of template / output file is in place.
xjules
force-pushed
the
draft_paramcfg
branch
from
80c5e43 to
1db64b4
Compare
xjules
commented
Feb 24, 2025
| ] | ||
| ) | ||
|
|
||
| def save_parameters( |
There was a problem hiding this comment.
TODO: redesign API for save_parameters?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #10088
Approach
Make new scalar parameter config
git rebase -i main --exec 'just rapid-tests')When applicable