Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead logic from endpoint #10165

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yngve-sk
Copy link
Contributor

Callback does not currently return anything, don't think we plan to let the callback interrupt the websocket from running anyway?

monitor.update does not return anything
@yngve-sk yngve-sk force-pushed the 25.02.27.remove-dead-logic-from-endpoint branch from b5b471a to 307e070 Compare February 27, 2025 09:17
Copy link

codspeed-hq bot commented Feb 27, 2025

CodSpeed Performance Report

Merging #10165 will improve performances by 10.73%

Comparing yngve-sk:25.02.27.remove-dead-logic-from-endpoint (307e070) with main (27a0895)

Summary

⚡ 1 improvements
✅ 24 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-summary-get_record_observations] 1.5 ms 1.3 ms +10.73%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant