Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output scaled controls to forwardmodel #10178

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yngve-sk
Copy link
Contributor

Issue
Resolves #8814

Should go in alongside PRs updating forward models to not do their own control scaling

Copy link

codspeed-hq bot commented Feb 28, 2025

CodSpeed Performance Report

Merging #10178 will improve performances by 14.04%

Comparing yngve-sk:25.02.28.output-scaled-controls-to-forwardmodel (b893661) with main (3965659)

Summary

⚡ 2 improvements
✅ 23 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_load_from_context[gen_x: 20, sum_x: 20 reals: 10] 7 ms 6.4 ms +10.57%
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-summary_with_obs-get_record_observations] 4 ms 3.5 ms +14.04%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output scaled control values from Everest
1 participant