Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pandas 2 #247

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Add support for pandas 2 #247

merged 3 commits into from
Mar 21, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Mar 19, 2024

Resolves #231

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.45%. Comparing base (0e1fbb6) to head (539fffa).

❗ Current head 539fffa differs from pull request most recent head 9554096. Consider uploading reports for the commit 9554096 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage   83.52%   83.45%   -0.08%     
==========================================
  Files          14       14              
  Lines        3072     3071       -1     
==========================================
- Hits         2566     2563       -3     
- Misses        506      508       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larsevj larsevj requested a review from berland March 19, 2024 12:49
@@ -10,7 +10,7 @@ exclude = docs,
test = pytest

[tool:pytest]
addopts = --verbose -x
addopts = --verbose
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(if we later revert the pandas2 thing, it would be strange to get this -x reintroduced, but no biggie..)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can separate everything that is not pandas related into its own commit.

Copy link
Collaborator

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@larsevj larsevj merged commit 5c39d6f into equinor:master Mar 21, 2024
6 checks passed
@larsevj larsevj deleted the support_pandas_2 branch March 21, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with Pandas 2.x
3 participants