Fix bug for integers in sunsch substitute #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #666 +/- ##
=======================================
Coverage 86.26% 86.26%
=======================================
Files 50 50
Lines 6990 6990
=======================================
Hits 6030 6030
Misses 960 960 ☔ View full report in Codecov by Sentry. |
|
This is a bug in release |
asnyv
added a commit
to asnyv/subscript
that referenced
this pull request
Feb 21, 2024
Fix bug for integers in sunsch substitute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #665
The issue was that certain inputs have to be
intto be parsed byopm, e.g. the VFP table number (added it to the test).Probably just a typo in the conversion to
pydanticasstrwas repeated twice in the typing.