Added function for handling manually mapped binaries #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ergrelet
reviewed
Feb 25, 2025
| const WCHAR* iatFixFile | ||
| ) | ||
| { | ||
| Scylla::initAsDll(); //Not entirely sure why - but this is required otherwise the module list is populated incorrectly. |
There was a problem hiding this comment.
This might need further investigation as it might hide a bug somewhere. How did you load Scylla when testing? initAsDll should have been called when loading Scylla's DLL into the process (when used as a DLL of course).
Could it be that the interaction with ScyllaIatSearchManual produces a weird state?
There was a problem hiding this comment.
Could it be that the interaction with ScyllaIatSearchManual produces a weird state?
Good point. It could have been. I'll try and have a look at this tomorrow sometime and see if that was the culprit.
It was quite a strange bug honestly, the ProcessAccessHelp::getProcessModules call would just fail without any error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this might be useful for the project. Currently there's no way to dump/fix the IAT like you can with the GUI in the case that the binary you are dumping is manually mapped and requires a manually specified image address. This adds a few functions to support that