Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple changes #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

exo-core
Copy link

This PR contains bundles multiple changes that I made recently, when integrating the library on our KUKA controller:

  • Implemented changes suggested in Fix string comparison #2 and Remove log #4
  • Rearranged repository structure:
    Before the repository contained a whole catkin workspace with a single package in it. Not it contains just a single ROS package that can be clone inside of an existing workspace.
  • Made constructors public, so that the package can be used a stand-alone library.
  • Added method to abort a goal to ActionServer

@fmessmer
Copy link

fmessmer commented Sep 15, 2018

@exo-core
have a look at https://github.com/CentralLabFacilities/rosjava_actionlib they also already implemented most of what you did...

wrt to setAborted, I added this on our fork which is merged with https://github.com/CentralLabFacilities/rosjava_actionlib:
👉 https://github.com/ernestmc/rosjava_actionlib/compare/master...mojin-robotics:kinetic?expand=1

@exo-core
Copy link
Author

@fmessmer Thanks for the info. I'll take a look as soon as I have some time (after IROS^^) 😉

fmessmer added a commit to fmessmer/rosjava_actionlib that referenced this pull request Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants