Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.4 support for 1.7.x by dropping support for PHP < 7.1 #899

Open
wants to merge 2 commits into
base: 1.7.x
Choose a base branch
from

Conversation

MyIgel
Copy link

@MyIgel MyIgel commented Jan 26, 2025

Ayesh and others added 2 commits January 26, 2025 18:33
…r PHP < 7.1

Fixes all issues that emit deprecation notices on PHP 8.4 for implicit nullable parameter type declarations.

See:
 - [RFC](https://wiki.php.net/rfc/deprecate-implicitly-nullable-types)
 - [PHP 8.4: Implicitly nullable parameter declarations deprecated](https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated)

(cherry picked from commit 7b307a9)
@MyIgel
Copy link
Author

MyIgel commented Jan 26, 2025

This could also be the fix for #897 when released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants